From 7dc9b20200a0211f93894bb7597c00aef8479e62 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Thu, 21 May 2009 19:26:08 +0000 Subject: [PATCH] fix confusing output when bit 0 of the idcode is not 1 as required by jtag spec git-svn-id: https://urjtag.svn.sourceforge.net/svnroot/urjtag/trunk@1610 b68d4a1b-bc3d-0410-92ed-d4ac073336b7 --- urjtag/ChangeLog | 4 ++++ urjtag/src/tap/detect.c | 7 ++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/urjtag/ChangeLog b/urjtag/ChangeLog index b785f3df..6345cefa 100644 --- a/urjtag/ChangeLog +++ b/urjtag/ChangeLog @@ -6,6 +6,10 @@ * configure.ac: enable -Werror by default only when building out of an scm, and add an explicit --enable-werror option to control it + * src/tap/detect.c: if the idcode failed to parse, don't print it out like it + actually worked but only returned zero's as this is confusing -- be clear + in that we didn't even attempt to read the idcode + 2009-05-19 Arnim Laeuger * data/Makefile.am, data/broadcom/bcm6348/bcm6348, diff --git a/urjtag/src/tap/detect.c b/urjtag/src/tap/detect.c index 32152b1f..3f990b7f 100644 --- a/urjtag/src/tap/detect.c +++ b/urjtag/src/tap/detect.c @@ -277,10 +277,11 @@ urj_tap_detect_parts (urj_chain_t *chain, const char *db_path) urj_tap_register_shift_left (id, 1); id->data[0] = 1; did = id; - } - urj_log (URJ_LOG_LEVEL_NORMAL, _("Device Id: %s (0x%016" PRIX64 ")\n"), - urj_tap_register_get_string (did), bits_to_uint64 (did)); + urj_log (URJ_LOG_LEVEL_NORMAL, _("Device Id: %s (0x%016" PRIX64 ")\n"), + urj_tap_register_get_string (did), bits_to_uint64 (did)); + } else + urj_log (URJ_LOG_LEVEL_NORMAL, _("Device Id: unknown as bit 0 was not a 1\n")); part = urj_part_alloc (did); if (part == NULL)