From 8f5fc697b87aad2d00b2acaa5cb27ecca33848b1 Mon Sep 17 00:00:00 2001
From: Rutger Hofman <rutger@cs.vu.nl>
Date: Tue, 5 May 2009 16:11:54 +0000
Subject: [PATCH] Fix warnings (and some of them were actually errors in a new
 API call)

git-svn-id: https://urjtag.svn.sourceforge.net/svnroot/urjtag/trunk@1567 b68d4a1b-bc3d-0410-92ed-d4ac073336b7
---
 urjtag/ChangeLog              | 16 ++++++++++++++++
 urjtag/src/bsdl/bsdl_sem.c    |  4 ++--
 urjtag/src/cmd/cmd_register.c |  1 -
 urjtag/src/global/urjtag.c    |  2 ++
 4 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/urjtag/ChangeLog b/urjtag/ChangeLog
index 1f5fb457..175d4bd9 100644
--- a/urjtag/ChangeLog
+++ b/urjtag/ChangeLog
@@ -1,3 +1,19 @@
+2009-05-05  Rutger Hofman <rfhh>
+
+  * include/urjtag/part.h, src/cmd/cmd_bus.c, src/cmd/cmd_detect.c,
+    src/cmd/cmd_signal.c, src/bsdl/bsdl_bison.y, src/part/instruction.c,
+    src/part/bsbit.c, src/part/part.c, src/part/signal.c: start replacing
+    calls to printf() with calls to urj_log(), for starters with src/part.
+    Sometimes that means fixing a function to return an error status where
+    it previously printed and returned void
+
+  * include/urjtag/data_register.h, include/urjtag/error.h,
+    include/urjtag/log.h, src/global/*.c, src/cmd/cmd_register.c,
+    src/cmd/cmd_instruction.c, src/bsdl/bsdl_sem.c, src/tap/detect.c,
+    src/part/data_register.c, src/svf/svf_flex.l, src/svf/svf.c,
+    src/flash/detectflash.c: transform a number of urj_cmd_run() calls into
+    API calls
+
 2009-05-04  Rutger Hofman <rfhh>
 
   * src/cmd/cmd_bus.c, src/bus/buses.c, include/urjtag/bus.h: transform the
diff --git a/urjtag/src/bsdl/bsdl_sem.c b/urjtag/src/bsdl/bsdl_sem.c
index a67e8ebc..56e9a636 100644
--- a/urjtag/src/bsdl/bsdl_sem.c
+++ b/urjtag/src/bsdl/bsdl_sem.c
@@ -336,7 +336,7 @@ urj_bsdl_process_cell_info (urj_bsdl_jtag_ctrl_t *jc)
         {
             if (jc->proc_mode & URJ_BSDL_MODE_INSTR_EXEC)
                 // @@@@ RFHH check result
-                (void)urj_part_bsbit_alloc_control (jc->chain, ci->bit_num,
+                (void)urj_part_bsbit_alloc_control (jc->part, ci->bit_num,
                                                     ci->port_name, type, safe,
                                                     ci->ctrl_bit_num,
                                                     ci->disable_safe_value,
@@ -351,7 +351,7 @@ urj_bsdl_process_cell_info (urj_bsdl_jtag_ctrl_t *jc)
         {
             if (jc->proc_mode & URJ_BSDL_MODE_INSTR_EXEC)
                 // @@@@ RFHH check result
-                (void)urj_part_bsbit_alloc (jc->chain, ci->bit_num,
+                (void)urj_part_bsbit_alloc (jc->part, ci->bit_num,
                                             ci->port_name, type, safe);
             if (jc->proc_mode & URJ_BSDL_MODE_INSTR_PRINT)
                 printf ("bit %d %s %c %d\n", ci->bit_num, ci->port_name,
diff --git a/urjtag/src/cmd/cmd_register.c b/urjtag/src/cmd/cmd_register.c
index 5fb7bf43..a6f1f523 100644
--- a/urjtag/src/cmd/cmd_register.c
+++ b/urjtag/src/cmd/cmd_register.c
@@ -42,7 +42,6 @@ cmd_register_run (urj_chain_t *chain, char *params[])
 {
     urj_part_t *part;
     unsigned int len;
-    urj_data_register_t *dr;
 
     if (urj_cmd_params (params) != 3)
         return -1;
diff --git a/urjtag/src/global/urjtag.c b/urjtag/src/global/urjtag.c
index f19a67eb..3c425956 100644
--- a/urjtag/src/global/urjtag.c
+++ b/urjtag/src/global/urjtag.c
@@ -100,4 +100,6 @@ urj_error_string (urj_error_t err)
     case URJ_ERROR_NO_BUS_DRIVER:       return "no bus driver";
     case URJ_ERROR_BUFFER_EXHAUSTED:    return "buffer exhausted";
     }
+
+    return "UNDEFINED ERROR";
 }