Corrected q->next_free updating in cable_add_queue_item to hopefully fix [1884952] Internal error

git-svn-id: https://urjtag.svn.sourceforge.net/svnroot/urjtag/trunk@996 b68d4a1b-bc3d-0410-92ed-d4ac073336b7

jtag/ChangeLog

@@ -1,3 +1,8 @@
+2008-02-05  Kolja Waschk <kawk>
+
+    * src/tap/cable.c: cable_queue_add_item didn't always correct q->next_free,
+         and a memory leak in cable_defer_transfer was fixed [1884952].
+
 2008-02-04  Arnim Laeuger  <arniml@users.sourceforge.net>
 
     * src/tap/cable/ft2232.c (ft2232_flush): rework flush implementation to benefit from

jtag/src/tap/cable.c

@@ -211,7 +211,6 @@ cable_add_queue_item( cable_t *cable, cable_queue_info_t *q )
               memcpy(&(q->data[q->max_items]), &(q->data[0]), 
                   q->next_free * sizeof(cable_queue_t));
 
-              q->next_free += q->max_items;
             }
             else
             {
@@ -227,13 +226,14 @@ cable_add_queue_item( cable_t *cable, cable_queue_info_t *q )
 
               memmove(&(q->data[0]), &(q->data[added_space]), 
                   (q->next_free - added_space) * sizeof(cable_queue_t));
-
-              q->next_free -= added_space;
             }
           }
 #endif
         }
         q->max_items = new_max_items;
+        q->next_free = q->next_item + q->num_items;
+        if(q->next_free >= new_max_items) q->next_free -= new_max_items;
+
 	}
 
 	i = q->next_free;
@@ -450,31 +450,35 @@ cable_transfer_late( cable_t *cable, char *out )
 int
 cable_defer_transfer( cable_t *cable, int len, char *in, char *out )
 {
-	char *dbuf;
-	int i = cable_add_queue_item( cable, &(cable->todo) );
-	if( i < 0 ) return 1; /* report failure */
-	cable->todo.data[i].action = CABLE_TRANSFER;
-	cable->todo.data[i].arg.transfer.len = len;
+	char *ibuf, *obuf = NULL;
+	int i;
 
-	dbuf = malloc(len);
-	if(dbuf == NULL) return 1; /* report failure */
-	if(in) memcpy(dbuf, in, len);
-	cable->todo.data[i].arg.transfer.in  = dbuf;
+	ibuf = malloc(len);
+	if(ibuf == NULL) return 1;
 
 	if(out)
 	{
-		dbuf = malloc(len);
-		if(dbuf == NULL)
+		obuf = malloc(len);
+		if(obuf == NULL)
 		{
-			free(cable->todo.data[i].arg.transfer.in);
-			return 1; /* report failure */
+			free(ibuf);
+			return 1;
 		}
-		cable->todo.data[i].arg.transfer.out = dbuf;
-	}
-	else
+	};
+
+	i = cable_add_queue_item( cable, &(cable->todo) );
+	if( i < 0 )
 	{
-		cable->todo.data[i].arg.transfer.out = NULL;
-	}
+		free(ibuf);
+		if(obuf) free(obuf);
+		return 1; /* report failure */
+	};
+
+	cable->todo.data[i].action = CABLE_TRANSFER;
+	cable->todo.data[i].arg.transfer.len = len;
+	if(in) memcpy(ibuf, in, len);
+	cable->todo.data[i].arg.transfer.in  = ibuf;
+	cable->todo.data[i].arg.transfer.out = obuf;
 	return 0; /* success */
 }